qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH] Wrong error message in block_passwd command


From: Markus Armbruster
Subject: Re: [Qemu-devel] Re: [PATCH] Wrong error message in block_passwd command
Date: Fri, 05 Mar 2010 17:47:49 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Shahar Havivi <address@hidden> writes:

> diff --git a/qerror.c b/qerror.c
> index 2f657f4..4e63a54 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -49,6 +49,10 @@ static const QErrorStringTable qerror_table[] = {
>          .desc      = "The %(device) is encrypted",
>      },
>      {
> +        .error_fmt = QERR_DEVICE_NOT_ENCRYPTED,
> +        .desc      = "Device '%(device)' is not encrypted",
> +    },
> +    {
>          .error_fmt = QERR_DEVICE_LOCKED,
>          .desc      = "Device %(device) is locked",
>      },
> diff --git a/qerror.h b/qerror.h
> index ee59615..b93fff6 100644
> --- a/qerror.h
> +++ b/qerror.h
> @@ -46,6 +46,9 @@ QError *qobject_to_qerror(const QObject *obj);
>  #define QERR_DEVICE_ENCRYPTED \
>      "{ 'class': 'DeviceEncrypted', 'data': { 'device': %s } }"
>  
> +#define QERR_DEVICE_NOT_ENCRYPTED \
> +    "{ 'class': 'DeviceNotEncrypted', 'data': { 'device': %s } }"
> +
>  #define QERR_DEVICE_LOCKED                                      \
>      "{ 'class': 'DeviceLocked', 'data': { 'device': %s } }"

Would you humor me and keep the error definitions sorted?  Thanks.


PS: Luiz has always put each new error in its own commit, and I followed
that practice.  Not sure we really care.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]