Re: [Qemu-devel] [PATCH RFC] net: add a flag to disable mac/vlan filtering

[Alex Williamson]

On Tue, 2010-03-09 at 08:43 -0600, Anthony Liguori wrote:
> On 03/09/2010 07:15 AM, Michael S. Tsirkin wrote:
> > New bridge in linux 2.6.34 adds IGMP snooping support,
> > after which bridge should not normally flood any packets.
> > While we still need mac table to arm forwarding tables
> > after migration, we can thus ignore it for rx datapath.
> >
> > For vlan, it's possible to do filtering down the
> > stack simply by using bridge per guest and binding said bridge
> > to vlan device, which some people do.
> >
> > Since qemu has no easy way to check IGMP snooping
> > support in bridge or how it's connected, add options
> > to disable rx filtering, so that management can set it
> > as appropriate.
> > Use these options to optimise virtio-net rx path.
> > We still ask guest for the list of vlans/macs for
> > migration.
> >
> > Signed-off-by: Michael S. Tsirkin<address@hidden>
> >    
> 
> Can't this be achieved by just disabling the feature bits?  IOW,
> 
> ctrl_vq=0,ctrl_vlan=0?

Michael still wants the guest to populate the MAC filter table so that
we can use it to announce MACs on the bridge, especially after a
migration.

Alex