Re: [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure

[Anthony Liguori]

On 03/09/2010 10:41 AM, Gerd Hoffmann wrote:
> On 03/09/10 17:28, Anthony Liguori wrote:
> > If a person has a guest that twiddles with LEDs, what are the chances
> > they are going to figure out that there's an option with VNC to not use
> > LED status as part of the modifier tracking heuristics?
> >
> > I don't think it's really useful. Like I said in an earlier note, we're
> > already dealing with a heuristics based algorithm because we're
> > attempting to detect dangling modifier presses. I'd rather see an option
> > that disabled the whole thing verses something specific to the LEDs.
>
> You are referring to the 
> do-i-should-insert-extra-capslock/numlock-events logic in do_key_event() ?

Yup.

>   Well, we can turn off both, fine with me, after all they sort-of 
> belong together.  Do you have an idea for a short 
> 'no-capslock-and-numlock-tracking-heuristics' option name?

Maybe 'toggle-key-tracking=on|off' with an appropriate documentation 
blurb.  I don't know, it doesn't sound like a good name to me.

Regards,

Anthony Liguori


> cheers,
>   Gerd