Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules

[Avi Kivity]

On 03/09/2010 07:08 PM, Anthony Liguori wrote:
> On 03/09/2010 10:38 AM, Paolo Bonzini wrote:
> > > > diff --git a/.gitmodules b/.gitmodules
> > > > index dd4745e..5217ce7 100644
> > > > --- a/.gitmodules
> > > > +++ b/.gitmodules
> > > > @@ -1,6 +1,6 @@
> > > >    [submodule "roms/vgabios"]
> > > >        path = roms/vgabios
> > > > -    url = ../vgabios.git
> > > > +    url = git://git.qemu.org/vgabios.git/
> > > >    [submodule "roms/seabios"]
> > > >        path = roms/seabios
> > > > -    url = ../seabios.git
> > > > +    url = git://git.qemu.org/seabios.git/
> > > Relative URLs are more friendly for users of proxies.
> > Users of proxies can still customize their .git/config file.  This
> > bug caused (or contributed to) a real problem in the qemu-kvm
> > releases (they do not include seabios/vgabios references).
>
> That's odd because Avi's the one who has historically advocated 
> relative URLs.

I can fix the reference problem by adding something to a README.  Using 
an absolute URL means users behind firewalls cannot clone the submodules 
anymore without tinkering with git config files.

--
error compiling committee.c: too many arguments to function