Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port.

[Stuart Brady]

On Wed, Mar 17, 2010 at 07:56:12AM -0700, Richard Henderson wrote:
> On 03/16/2010 06:58 PM, Stuart Brady wrote:
> > The tcg_reg_free() calls worry me slightly, but I assume they're safe...
> 
> Yeah, that one's rather gross.
> 
> Since Aurelien's generic div/rem patch I could simply remove all
> that millicode stuff, including that tcg_reg_free, and let the
> generic code handle this instead.  Which would get to the same
> millicode routine via one or two extra levels of indirection.
> 
> Thoughts?

Well, assuming that the millicode stuff does indeed work, I wouldn't worry
too much about it...  I only imagine that this is something that other
archs might need to do too, so it'd be worth doing as cleanly as possible.

Likewise, the qemu_ld/qemu_st refactoring should really be done for other
archs at some later stage, too, as it's quite a significant improvement in
readability of the code.

Cheers,
-- 
Stuart Brady