[Qemu-devel] Re: [PATCH 04/11] error: New QERR_INVALID_PARAMETER_VALUE

[Luiz Capitulino]

On Thu, 18 Mar 2010 17:33:11 +0100
Markus Armbruster <address@hidden> wrote:

> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  qerror.c |    4 ++++
>  qerror.h |    3 +++
>  2 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/qerror.c b/qerror.c
> index 9fb817e..97e8d4a 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -121,6 +121,10 @@ static const QErrorStringTable qerror_table[] = {
>          .desc      = "Invalid parameter type, expected: %(expected)",
>      },
>      {
> +        .error_fmt = QERR_INVALID_PARAMETER_VALUE,
> +        .desc      = "Parameter '%(name)' expects %(expected)",
> +    },

 Would we need this error if we improve QERR_INVALID_PARAMETER to
accept an optional 'expects' parameter?

> +    {
>          .error_fmt = QERR_INVALID_PASSWORD,
>          .desc      = "Password incorrect",
>      },
> diff --git a/qerror.h b/qerror.h
> index 870cdc3..5625d54 100644
> --- a/qerror.h
> +++ b/qerror.h
> @@ -106,6 +106,9 @@ QError *qobject_to_qerror(const QObject *obj);
>  #define QERR_INVALID_PARAMETER_TYPE \
>      "{ 'class': 'InvalidParameterType', 'data': { 'name': %s,'expected': %s 
> } }"
>  
> +#define QERR_INVALID_PARAMETER_VALUE \
> +    "{ 'class': 'InvalidParameterValue', 'data': { 'name': %s, 'expected': 
> %s } }"
> +
>  #define QERR_INVALID_PASSWORD \
>      "{ 'class': 'InvalidPassword', 'data': {} }"
>