qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] monitor: convert do_device_del() to QObject, QE


From: Markus Armbruster
Subject: [Qemu-devel] Re: [PATCH] monitor: convert do_device_del() to QObject, QError
Date: Fri, 19 Mar 2010 22:35:16 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Luiz Capitulino <address@hidden> writes:

> On Wed, 17 Mar 2010 17:46:07 +0100
> Markus Armbruster <address@hidden> wrote:
>
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  hw/qdev.c       |    7 ++++---
>>  hw/qdev.h       |    2 +-
>>  qemu-monitor.hx |    3 ++-
>>  3 files changed, 7 insertions(+), 5 deletions(-)
>> 
>> diff --git a/hw/qdev.c b/hw/qdev.c
>> index 17a46a7..35460eb 100644
>> --- a/hw/qdev.c
>> +++ b/hw/qdev.c
>> @@ -800,15 +800,16 @@ int do_device_add(Monitor *mon, const QDict *qdict, 
>> QObject **ret_data)
>>      return 0;
>>  }
>>  
>> -void do_device_del(Monitor *mon, const QDict *qdict)
>> +int do_device_del(Monitor *mon, const QDict *qdict, QObject **ret_data)
>>  {
>>      const char *id = qdict_get_str(qdict, "id");
>>      DeviceState *dev;
>>  
>>      dev = qdev_find_recursive(main_system_bus, id);
>>      if (NULL == dev) {
>> -        error_report("Device '%s' not found", id);
>> -        return;
>> +        qerror_report(QERR_DEVICE_NOT_FOUND, id);
>> +        return -1;
>>      }
>>      qdev_unplug(dev);
>
>  This function can fail, otherwise looks good.

Thanks, will fix.

[...]




reply via email to

[Prev in Thread] Current Thread [Next in Thread]