[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 0/4] monitor: Convert do_set_link() to QObject, QErr
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError |
Date: |
Tue, 23 Mar 2010 11:27:54 +0100 |
PATCH 3/4 changes syntax of set_link's second argument from up|down to
on|off. I feel that the argument needs to be boolean in QMP, and this
is the simplest way to get it.
Alternatives I could try if the syntax change is unwanted:
* Use the old string argument in QMP. Easy.
* Don't convert set_link, create a new command with a boolean
argument.
* Create a argument parser for up|down.
Markus Armbruster (4):
monitor: Rename argument type 'b' to 'f'
monitor: New argument type 'b'
monitor: Use argument type 'b' for set_link
monitor: Convert do_set_link() to QObject, QError
monitor.c | 39 +++++++++++++++++++++++++++++++++++----
net.c | 17 ++++++-----------
net.h | 2 +-
qemu-monitor.hx | 13 +++++++------
4 files changed, 49 insertions(+), 22 deletions(-)
- [Qemu-devel] [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError,
Markus Armbruster <=
[Qemu-devel] [PATCH 4/4] monitor: Convert do_set_link() to QObject, QError, Markus Armbruster, 2010/03/23
[Qemu-devel] [PATCH 1/4] monitor: Rename argument type 'b' to 'f', Markus Armbruster, 2010/03/23
[Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError, Luiz Capitulino, 2010/03/24