[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 4/9] virtio-serial: Handle scatter-gather bu
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] Re: [PATCH 4/9] virtio-serial: Handle scatter-gather buffers for control messages |
Date: |
Tue, 23 Mar 2010 21:45:08 +0530 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On (Tue) Mar 23 2010 [17:51:26], Michael S. Tsirkin wrote:
> On Mon, Mar 22, 2010 at 10:48:02AM +0530, Amit Shah wrote:
> > On (Sat) Mar 20 2010 [09:40:50], Avi Kivity wrote:
> > > On 03/19/2010 01:58 PM, Amit Shah wrote:
> > >> +
> > >> + offset = 0;
> > >> + for (i = 0; i< elem.out_num; i++) {
> > >> + memcpy(buf + offset, elem.out_sg[i].iov_base,
> > >> + elem.out_sg[i].iov_len);
> > >> + offset += elem.out_sg[i].iov_len;
> > >> + }
> > >> + len = cur_len;
> > >> +
> > >> + handle_control_message(vser, buf, len);
> > >> + virtqueue_push(vq,&elem, len);
> > >> + }
> > >> + if (len) {
> > >> + qemu_free(buf);
> > >> }
> > >> virtio_notify(vdev, vq);
> > >> }
> > >
> > > Isn't there some virtio function to linearize requests?
> >
> > I don't see one.
>
> virtio-net has iov_fill. Reuse it?
Hm, yeah. Any ideas on how to share it? Put it in some common file?
Just copying it seems good for now..
Amit
- [Qemu-devel] [PATCH 3/9] virtio-serial: save/load: Ensure we have hot-plugged ports instantiated, (continued)
- [Qemu-devel] [PATCH 3/9] virtio-serial: save/load: Ensure we have hot-plugged ports instantiated, Amit Shah, 2010/03/19
- [Qemu-devel] [PATCH 4/9] virtio-serial: Handle scatter-gather buffers for control messages, Amit Shah, 2010/03/19
- [Qemu-devel] [PATCH 5/9] virtio-serial: Handle scatter/gather input from the guest, Amit Shah, 2010/03/19
- [Qemu-devel] [PATCH 6/9] virtio-serial: Remove redundant check for 0-sized write request, Amit Shah, 2010/03/19
- [Qemu-devel] [PATCH 7/9] virtio-serial: Update copyright year to 2010, Amit Shah, 2010/03/19
- [Qemu-devel] [PATCH 8/9] virtio-serial-bus: Use a bitmap in virtio config space for active ports, Amit Shah, 2010/03/19
- [Qemu-devel] [PATCH 9/9] virtio-serial-bus: Let the guest know of host connection changes after migration, Amit Shah, 2010/03/19
- [Qemu-devel] Re: [PATCH 4/9] virtio-serial: Handle scatter-gather buffers for control messages, Avi Kivity, 2010/03/20
- Re: [Qemu-devel] Re: [PATCH 4/9] virtio-serial: Handle scatter-gather buffers for control messages, Amit Shah, 2010/03/22
- Re: [Qemu-devel] Re: [PATCH 4/9] virtio-serial: Handle scatter-gather buffers for control messages, Michael S. Tsirkin, 2010/03/23
- Re: [Qemu-devel] Re: [PATCH 4/9] virtio-serial: Handle scatter-gather buffers for control messages,
Amit Shah <=
- Re: [Qemu-devel] Re: [PATCH 4/9] virtio-serial: Handle scatter-gather buffers for control messages, Michael S. Tsirkin, 2010/03/23
[Qemu-devel] Re: [PATCH 0/9] virtio-serial fixes, ABI updates, Michael S. Tsirkin, 2010/03/21