Re: [Qemu-devel] git head broken? (x86 softmmu w/o kvm)

[Markus Armbruster]

Anthony Liguori <address@hidden> writes:

> Hi,
>
> On 03/23/2010 02:24 PM, Blue Swirl wrote:
>> On 3/23/10, Aurelien Jarno<address@hidden>  wrote:
>>    
>>> On Tue, Mar 23, 2010 at 03:27:26AM +0100, Aurelien Jarno wrote:
>>>   >  On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote:
>>>   >  >  Hi!
>>>   >  >
>>>   >  >   I just wanted to make another FreeBSD qemu git head snaphot port 
>>> update,
>>>   >  >  and found both i386-softmmu and x86_64-softmmu no longer boot, they 
>>> seem
>>>   >  >  to hang early in the bios before it prints anything, last tb seems 
>>> to be
>>>   >  >  this loop:
>>>   >  >
>>>   >
>>>   >  A quick bisect revealed it has been broken by this patch:
>>>   >
>>>
>>>
>>> I have just pushed a patch to fix the problem.
>>>      
>> Thanks, sorry for the trouble.
>>    
>
> It would be nice to send a series like this to the list first in the
> future to give people a heads up.  It's a useful set of clean-ups but
> it's nice to give people a chance to provide input.

It's not merely "nice", it's how we work.  It's a far more important and
useful rule than where to put the curlies and such.

And yes, the patch series is good stuff.