qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/15] virtio-serial: save/load: Ensure nr_ports


From: Jamie Lokier
Subject: Re: [Qemu-devel] [PATCH 02/15] virtio-serial: save/load: Ensure nr_ports on src and dest are same.
Date: Fri, 26 Mar 2010 01:09:23 +0000
User-agent: Mutt/1.5.13 (2006-08-11)

Amit Shah wrote:
> The number of ports on the source as well as the destination machines
> should match. If they don't, it means some ports that got hotplugged on
> the source aren't instantiated on the destination. Or that ports that
> were hot-unplugged on the source are created on the destination.

Surely the set of guest-visible ids must match exactly and be checked
(maybe mapped, if they were given in a different order), in which case
counting the number of ports looks redundant.

I.e. is this check hiding the omission of the proper one?

-- Jamie




reply via email to

[Prev in Thread] Current Thread [Next in Thread]