Re: [Qemu-devel] [PATCH][RESEND] Serial: DOS Plus regression

[Aurelien Jarno]

On Thu, Mar 25, 2010 at 08:58:13PM +0800, Roy Tam wrote:
> The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents
> booting Digital Research DOSPlus. Following patch partially reverts
> that commit and makes DOSPlus booting in QEMU again.

I guess that this patch has been introduced to fix an issue. Are you
sure your partial revert is correct and is not going to create a 
regression? What the documentation says?

> Sign-off-by: Roy Tam <address@hidden>
> 
> --
> 
> diff --git a/hw/serial.c b/hw/serial.c
> index f3ec36a..2ae550e 100644
> --- a/hw/serial.c
> +++ b/hw/serial.c
> @@ -401,10 +401,6 @@ static void serial_ioport_write(void *opaque,
>                       s->poll_msl = 0;
>                  }
>              }
> -            if (s->lsr & UART_LSR_THRE) {
> -                s->thr_ipending = 1;
> -                serial_update_irq(s);
> -            }
>          }
>          break;
>      case 2:
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net