Re: [Qemu-devel] [RFC][PATCH 6/7] blkdebug: Add events and rules

[Christoph Hellwig]

On Mon, Mar 15, 2010 at 06:08:34PM +0100, Kevin Wolf wrote:
> +    fprintf(stderr, "bdrv_debug_event: %d\n", event);

Is this supposed to be in the final version or a leftover debugging aid?

> +#define BLKDBG_EVENT(bs, evt) bdrv_debug_event(bs, evt)

Why not call bdrv_debug_event directly?

> +    config = strdup(filename);
> +    config[c - filename] = '\0';
> +    ret = read_config(s, config);
> +    if (ret < 0) {
> +        return ret;
> +    }
> +    filename = c + 1;
> +
> +    /* Open the backing file */
> +    ret = bdrv_file_open(&s->hd, filename, flags);
> +    if (ret < 0) {
> +        return ret;
> +    }
> +
> +    return 0;

Don't we need to free config somewhere?