[Qemu-devel] Re: [PATCH] Elo touchpad 10 bytes emulator v2

[Ricardo Ribalda Delgado]

Hello Juan

  New patch is on the mail.

> It misses a SOB line.

  Sorry, I don't understand what you mean here, do you mean the sing off?

> You can remove the "../" from those, Makefile sets correct include paths
> for this to work.

Done

>
>> +    /*Move event*/
>> +    if (is_down&&buttons_state){
>> +         bytes[2]=0x2;
>
> Can we use some constant from that bytes[2] values? 0x1, 0x2 and 0x4
> don't look specially descriptive.
>

Done

>
> Why does the lenght of the FIFO changes here?  I think this change in
> independent of the rest of the patch (no knowledge about the 16550A to
> know if it should be 16 or 32).

Fixed using qemu_chr_can_read(). Thanks for your help!

>
> Later, Juan.
>

 Hope this time the patch is better.

       Regards

-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/