[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 09/17] virtio-serial: Propagate errors in initialisi
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH 09/17] virtio-serial: Propagate errors in initialising ports / devices in guest |
Date: |
Wed, 31 Mar 2010 13:04:00 +0530 |
If adding of ports or devices in the guest fails we can send out a QMP
event so that management software can deal with it.
Signed-off-by: Amit Shah <address@hidden>
---
hw/virtio-serial-bus.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index a19e751..33083af 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -223,6 +223,11 @@ static void handle_control_message(VirtIOSerial *vser,
void *buf)
switch(cpkt.event) {
case VIRTIO_CONSOLE_DEVICE_READY:
+ if (!cpkt.value) {
+ error_report("virtio-serial-bus: Guest failure in adding device
%s\n",
+ vser->bus->qbus.name);
+ break;
+ }
/*
* The device is up, we can now tell the device about all the
* ports we have here.
@@ -233,6 +238,11 @@ static void handle_control_message(VirtIOSerial *vser,
void *buf)
break;
case VIRTIO_CONSOLE_PORT_READY:
+ if (!cpkt.value) {
+ error_report("virtio-serial-bus: Guest failure in adding port %u
for device %s\n",
+ port->id, vser->bus->qbus.name);
+ break;
+ }
/*
* Now that we know the guest asked for the port name, we're
* sure the guest has initialised whatever state is necessary
--
1.6.2.5
- [Qemu-devel] [PATCH 00/17] v4: virtio-serial fixes, new abi for port discovery, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 01/17] virtio-serial: save/load: Ensure target has enough ports, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 02/17] virtio-serial: save/load: Ensure nr_ports on src and dest are same., Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 03/17] virtio-serial: save/load: Ensure we have hot-plugged ports instantiated, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 04/17] virtio-serial: save/load: Send target host connection status if different, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 05/17] virtio-serial: Use control messages to notify guest of new ports, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 06/17] virtio-serial: whitespace: match surrounding code, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 07/17] virtio-serial: Remove redundant check for 0-sized write request, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 08/17] virtio-serial: Update copyright year to 2010, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 09/17] virtio-serial: Propagate errors in initialising ports / devices in guest,
Amit Shah <=
- [Qemu-devel] [PATCH 10/17] virtio-serial: Send out guest data to ports only if port is opened, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 11/17] iov: Introduce a new file for helpers around iovs, add iov_from_buf(), Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 12/17] iov: Add iov_to_buf and iov_size helpers, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 13/17] virtio-serial: Handle scatter-gather buffers for control messages, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 14/17] virtio-serial: Handle scatter/gather input from the guest, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 15/17] virtio-serial: Apps should consume all data that guest sends out / Fix virtio api abuse, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 16/17] virtio-serial: Discard data that guest sends us when ports aren't connected, Amit Shah, 2010/03/31
- [Qemu-devel] [PATCH 17/17] virtio-serial: Implement flow control for individual ports, Amit Shah, 2010/03/31
- [Qemu-devel] Re: [PATCH 16/17] virtio-serial: Discard data that guest sends us when ports aren't connected, Juan Quintela, 2010/03/31
- Re: [Qemu-devel] [PATCH 15/17] virtio-serial: Apps should consume all data that guest sends out / Fix virtio api abuse, Gerd Hoffmann, 2010/03/31