Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

[Markus Armbruster]

Shahar Havivi <address@hidden> writes:

> On Fri, Mar 26, 2010 at 10:57:58AM +0100, Markus Armbruster wrote:
[...]
>> Since the index is not a stable identifier of keyboards, and we support
>> multiple monitors, you're prone to remove the wrong keyboard.
>> 
>>     Monitor#1                           Monitor#2
>>     "info keyboard" to find the index
>>                                         unplug a keyboard, invalidating
>>                                         index
>>     keyboard_set <index>
>> 
>> I think it's best to use a stable ID, like we do in other places.  We
>> commonly let the user specify it, e.g. as id=ID in -netdev, -device and
>> elswhere.
> What do we do when user not specify id for device?

Two obvious options: make one up (problem: clashes), or stipulate "if
you want to keyboard_set this keyboard, you must specify an id for it".

[...]