Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

[Paul Brook]

>        This patch adds support for virtio-rng. Data is read from a chardev
> and can be either raw entropy or received via the EGD protocol.

I still don't get why you need this at all. It seems like virtio-serial would 
already provides everything you need.

> +        qemu_gettimeofday(&now);

Using qemu_gettimeofday is almost certainly wrong, and you want to be using 
virtual time.  Plus I'm not convinced this is the right place to enforce rate 
limiting.

Paul