[Qemu-devel] Re: [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once

[Anthony Liguori]

On 04/02/2010 10:11 AM, Paolo Bonzini wrote:
> On 04/02/2010 05:08 PM, Anthony Liguori wrote:
> > Having kvm-all.c compile with and without CONFIG_KVM is pretty ugly 
> > IMHO.
> >
> > Is compiling vl.c once really that important of a goal?
>
> I didn't do this to compile vl.c once.  I don't care about that.
>
> I did this as an initial step towards having kvm functions stubbed out 
> for !CONFIG_KVM, instead of relying on GCC performing 
> dead-code-elimination on kvm_enabled().

I'd prefer a kvm-stub.c implementation as opposed to mixing in 
CONFIG_KVM in kvm-all.c

Regards,

Anthony Liguori

> Paolo