qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18b


From: Anthony Liguori
Subject: Re: [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build
Date: Fri, 02 Apr 2010 10:27:57 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 04/02/2010 09:30 AM, Stefan Weil wrote:
Blue Swirl schrieb:
On 4/2/10, Roy Tam<address@hidden>  wrote:
2010/4/2 Anthony Liguori<address@hidden>:

Try doing a clean build
This is a fresh checkout.
I can confirm this with mingw32:
LINK sparc64-softmmu/qemu-system-sparc64.exe
virtio-net.o: In function `virtio_net_exit':
/src/qemu/hw/virtio-net.c:943: undefined reference to `_tap_get_vhost_net'
virtio-net.o: In function `virtio_net_save':
/src/qemu/hw/virtio-net.c:719: undefined reference to `_tap_get_vhost_net'
virtio-net.o: In function `virtio_net_reset':
/src/qemu/hw/virtio-net.c:122: undefined reference to `_tap_get_vhost_net'
virtio-net.o: In function `virtio_net_set_status':
/src/qemu/hw/virtio-net.c:863: undefined reference to `_tap_get_vhost_net'
/src/qemu/hw/virtio-net.c:870: undefined reference to `_tap_get_vhost_net'
virtio-net.o:/src/qemu/hw/virtio-net.c:878: more undefined references
to `_tap_get_vhost_net' follow
collect2: ld returned 1 exit status
A cross build (mingw32 on debian) also results in this linker error.
The reason is quite simple: tap.o (which provides tap_get_vhost_net)
is only build for posix systems, but not for windows:

Makefile.objs:net-nested-$(CONFIG_POSIX) += tap.o

Changing this does not help because tap.c does not
compile for win32 without errors. Either these errors
have to be fixed, or don't call tap_get_vhost_net when
compiling for win32.

This tap files are a bit odd. We don't compile tap.o for mingw32 but we do compile tap-win32.o so what we need to do is define tap_get_vhost_net in tap-win32.c. Testing a patch right now.

Regards,

Anthony Liguori

Stefan








reply via email to

[Prev in Thread] Current Thread [Next in Thread]