[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Revert bogus usb-ohci change
From: |
Paul Brook |
Subject: |
[Qemu-devel] Revert bogus usb-ohci change |
Date: |
Sun, 4 Apr 2010 21:30:23 +0100 |
User-agent: |
KMail/1.12.4 (Linux/2.6.33-2-amd64; KDE/4.3.4; x86_64; ; ) |
Commit f1698408 "Compile usb-ohci only once" introduces a "be" property to the
pci-ohci device. The PCI bus is always little-endian, so this is completely
bogus. A hypothetical big-endian device would actually introduce another
byteswap.
As discussed previously, if you really want to avoid compiling the device
multiple times then this needs to be fixed elsewhere. Adding user visible
properties to devices is definitely not the right solution.
I have reverted this change. If there are other devices that have been hacked
in the same way then please revert those too.
Paul
- [Qemu-devel] Revert bogus usb-ohci change,
Paul Brook <=