[Qemu-devel] Re: Revert bogus usb-ohci change

[Blue Swirl]

On 4/4/10, Paul Brook <address@hidden> wrote:
> Commit f1698408 "Compile usb-ohci only once" introduces a "be" property to the
>  pci-ohci device. The PCI bus is always little-endian, so this is completely
>  bogus. A hypothetical big-endian device would actually introduce another
>  byteswap.

Then why there are again byte swaps with big endian target, aren't
they bogus too? Because we don't have the byte swapping bus yet.
Current system is bogus in this respect, so I claim that in general,
the level of bogosity was not changed.

>  As discussed previously, if you really want to avoid compiling the device
>  multiple times then this needs to be fixed elsewhere. Adding user visible
>  properties to devices is definitely not the right solution.
>
>  I have reverted this change. If there are other devices that have been hacked
>  in the same way then please revert those too.

I agree that the user visible property solution was wrong, sorry.

I had a patch "Compile rtl8139 and e1000 only once", which had "be"
property too but I didn't commit it because the property passing
didn't feel right and I didn't have a plan how to pass that from
higher levels.

Other patches didn't use the property method.