|
From: | Paul Brook |
Subject: | Re: [Qemu-devel] [PATCH 6/9] eepro100: Support compilation without EEPROM |
Date: | Wed, 7 Apr 2010 02:00:22 +0100 |
User-agent: | KMail/1.12.4 (Linux/2.6.33-2-amd64; KDE/4.3.4; x86_64; ; ) |
> To emulate hardware without an EEPROM, > EEPROM_SIZE may be set to 0. If might, but it isn't. This patch introduces a condition that will never be false. Please don't do that. I consider code that is never used to be actively harmful. Any feature that requires the user hack the source may as well not exist. The only possible exception is debug output intended solely for qemu developers. If there's something worth noting for future reference then add a proper comment, if necessary marked as TODO/FIXME. Paul
[Prev in Thread] | Current Thread | [Next in Thread] |