[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] virtio-blk: Fix use after release in virtio_blk_han
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [PATCH] virtio-blk: Fix use after release in virtio_blk_handle_rw_error |
Date: |
Wed, 07 Apr 2010 13:47:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
virtio_blk_req_complete releases the request we dereference again for
bdrv_mon_event. Reorder both calls to fix this.
Signed-off-by: Jan Kiszka <address@hidden>
---
hw/virtio-blk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index 9915840..d5e8c79 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -76,8 +76,8 @@ static int virtio_blk_handle_rw_error(VirtIOBlockReq *req,
int error,
bdrv_mon_event(req->dev->bs, BDRV_ACTION_STOP, is_read);
vm_stop(0);
} else {
- virtio_blk_req_complete(req, VIRTIO_BLK_S_IOERR);
bdrv_mon_event(req->dev->bs, BDRV_ACTION_REPORT, is_read);
+ virtio_blk_req_complete(req, VIRTIO_BLK_S_IOERR);
}
return 1;
- [Qemu-devel] [PATCH] virtio-blk: Fix use after release in virtio_blk_handle_rw_error,
Jan Kiszka <=