[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-blk: Fix use after release in virtio_blk
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH] virtio-blk: Fix use after release in virtio_blk_handle_rw_error |
|
Date: |
Wed, 07 Apr 2010 14:18:26 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 |
Am 07.04.2010 13:57, schrieb Christoph Hellwig:
> On Wed, Apr 07, 2010 at 01:47:47PM +0200, Jan Kiszka wrote:
>> virtio_blk_req_complete releases the request we dereference again for
>> bdrv_mon_event. Reorder both calls to fix this.
>
> I think Kevin alreday sent a patch to use the local state variable
> which is still around. Either way looks fine to me.
Yes, it's the same thing, so I won't pick this up for my block branch
even though Jan's fix looks fine, too.
Kevin