qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 4/4] tcg-hppa: Don't try to calls to non-constant ad


From: Richard Henderson
Subject: [Qemu-devel] [PATCH 4/4] tcg-hppa: Don't try to calls to non-constant addresses.
Date: Thu, 8 Apr 2010 01:24:35 +0200

PA-RISC uses procedure descriptors.  We'd need to emit a call to
the millicode routine $$dyncall.  However, this situation doesn't
actually arise, since we always have the descriptor available at
TCG code generation time.

Signed-off-by: Richard Henderson <address@hidden>
---
 tcg/hppa/tcg-target.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/tcg/hppa/tcg-target.c b/tcg/hppa/tcg-target.c
index aaa39e3..a8cb768 100644
--- a/tcg/hppa/tcg-target.c
+++ b/tcg/hppa/tcg-target.c
@@ -1276,8 +1276,10 @@ static inline void tcg_out_op(TCGContext *s, TCGOpcode 
opc, const TCGArg *args,
         if (const_args[0]) {
             tcg_out_call(s, (void *)args[0]);
         } else {
-            tcg_out32(s, INSN_BLE_SR4 | INSN_R2(args[0]));
-            tcg_out_mov(s, TCG_REG_RP, TCG_REG_R31);
+            /* ??? FIXME: the value in the register in args[0] is almost
+               certainly a procedure descriptor, not a code address.  We
+               probably need to use the millicode $$dyncall routine.  */
+            tcg_abort();
         }
         break;
 
-- 
1.6.2.5





reply via email to

[Prev in Thread] Current Thread [Next in Thread]