[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images |
Date: |
Thu, 08 Apr 2010 09:53:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 |
Am 07.04.2010 17:02, schrieb Stefan Hajnoczi:
> On Wed, Apr 7, 2010 at 12:57 PM, Christoph Hellwig <address@hidden> wrote:
>> Various obscure image format drivers do not allow write access.
>> Instead of silently falling back to read-only access reject attempts
>> to open these images for write access.
>
> Does block/curl.c need this too?
Yes, looks like it. It even fails to declare itself readonly like those
other formats do currently. One more argument for doing it in a central
place where no driver would be missed.
Kevin