Re: [Qemu-devel] [PATCH 06/18] tcg/arm: add defines for the allowed instructions set

[Richard Henderson]

On 04/07/2010 10:51 AM, Aurelien Jarno wrote:
> +#if defined(__ARM_ARCH_5T__) || \
> +    defined(__ARM_ARCH_5TE__) || \
> +    defined(__ARM_ARCH_5TEJ__) || \
> +    defined(__ARM_ARCH_6__) || \
> +    defined(__ARM_ARCH_7A__) || \
> +    defined(__ARM_ARCH_7__)
> +# define USE_ARMV5_INSTRUCTIONS 1
> +#endif

Wouldn't it be better to add a zero definition here
so that you can use C if's and not ifdefs, so as to
make sure that all code paths are semantically correct.
It's very easy to introduce a typo in a code path that
isn't used by a particular host's build.


r~