|
From: | Paul Brook |
Subject: | Re: [Qemu-devel] [PATCH] microblaze: fix build on Ubuntu Hardy |
Date: | Fri, 9 Apr 2010 00:48:21 +0100 |
User-agent: | KMail/1.12.4 (Linux/2.6.33-2-amd64; KDE/4.3.4; x86_64; ; ) |
> { > - fprintf_ftype fprintf = info->fprintf_func; > void * stream = info->stream; I'm pretty sure this is not the correct fix. "Fix a warning" is not sufficient justification for any change. We need to understand what was wrong with the old code, and why the new code is correct. Paul
[Prev in Thread] | Current Thread | [Next in Thread] |