Re: [Qemu-devel] [PATCH] Fix cross compilation

[Stefan Weil]

Aurelien Jarno schrieb:
> On Sat, Apr 10, 2010 at 09:34:31AM +0200, Stefan Weil wrote:
>> Aurelien Jarno schrieb:
>>> On Sun, Mar 28, 2010 at 11:44:05AM +0200, Stefan Weil wrote:
>>>> This patch enhances the algorithm which finds the correct settings
>>>> for SDL.
>>>> For cross compilations (when cross_prefix is set), it looks for
>>>> sdl-config
>>>> with cross prefix. Here is the complete search order:
>>>>
>>>> ${cross_prefix}sdl_config (new, only used for cross compilation)
>>>> $(cross_prefix}pkg-config (old)
>>>> pkg-config (old, needs PATH)
>>>> sdl-config (old, needs PATH)
>>> Why a different order for cross-compilation than for native
>>> compilation? I would expect the same order in both case, that is
>>> pkg-config first, and then sdl_config. The general rule, not specific to
>>> QEMU, is to prefer pkg-config over *config programs.
>>>
>> Maybe the correct solution should be
>>
>> $(cross_prefix}pkg-config (old)
>> ${cross_prefix}sdl_config (new, only used for cross compilation)
>
> Why sdl_config only for cross compilation? If $(cross_prefix} is not set
> for native compilation, always looking for:
>
> - first to $(cross_prefix}pkg-config
> - and then to ${cross_prefix}sdl-config
>
> looks the way to go.

D'accord. That's what I wanted to say.
The "only used for cross compilation" was too much copy + paste.