Re: [Qemu-devel] Weird thing happen when the VM is stop! (0.12.3)

[Jun Koi]

On Sat, Apr 10, 2010 at 3:09 AM, Marcelo Tosatti <address@hidden> wrote:
> On Sat, Apr 10, 2010 at 01:12:27AM +0900, Jun Koi wrote:
>> On Fri, Apr 9, 2010 at 10:20 PM, Luiz Capitulino <address@hidden> wrote:
>> > On Fri, 9 Apr 2010 18:32:21 +0900
>> > Jun Koi <address@hidden> wrote:
>> >
>> >> Hi,
>> >>
>> >> I found something very funny happening with 0.12.3: it seems the VM is
>> >> still running even I already stopped it.
>> >>
>> >> Here is how I verified that: Boot any OS (I checked with Windows XP
>> >> and Ubuntu) with 0.12.3, and stop it any time after it booted up. Use
>> >> "stop" command on monitor interface.
>> >>
>> >> Now the VM stops. Then in the same monitor interface, run "info
>> >> registers" again and again. You can see that the value of EIP and
>> >> EFLAGS still change once in a while. This should not happen, becaues
>> >> the VM already stopped.
>> >>
>> >> I checked, and dont see this problem with 0.11.1. And this doesnt
>> >> happen with the latest code in the git tree, either.
>> >>
>> >> Any idea on why this happens???
>> >
>> >  Can you try commit 55274a305 ? If it fixes the problem we need it
>> > in stable, if it doesn't you can try to find the fix by using git bisect.
>> >
>>
>> This hint makes sense, but the point is that I tried with some commits
>> before that 55274a305, and didnt see the problem. Still I am not sure
>> the problem is already fixed before 55274a305, or I am just unlucky
>> enough not see the problem when testing.
>>
>> After bisecting, I can say that the culprit is the below patch, from Marcelo.
>>
>> Now I am wondering if the above commit 55274a305 of Paolo Bonzini
>> fixed the bug, or other commit before that?? We should find the
>> correct fix, and port it to 0.12.4.
>
> Guess its c5f32c99. Can you confirm please?

I back-ported this patch to 0.12.3, and it seems the problem is gone.

Thanks,
J