[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [libvirt] Libvirt debug API
From: |
Chris Lalancette |
Subject: |
Re: [Qemu-devel] Re: [libvirt] Libvirt debug API |
Date: |
Mon, 12 Apr 2010 09:56:50 -0400 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 |
On 04/12/2010 08:41 AM, Daniel P. Berrange wrote:
>>> I don't think there's much to be gained from having an XML element to
>>> turn on/off use of these APIs. If an app doesn't want to use them, it
>>> can simply not link to libvirt-qemu.so
>>
>> The reason I wanted to do this was mostly for debug/support reasons.
>> That is, with this element in place we can easily tell from the dumpxml
>> output whether a person was using the "unreliable" API's, and thus we can
>> tell them to try and reproduce without that in place.
>
> That doesn't tell you whether they have actually used any API or not.
> It is also inconvenient if you start a guest without it, and only later
> realize you want to use the extra APIs. If we want to track the actual
> usage, then the first time a direct monitor command is issued, we should
> simply log a warning message.
The problem with logging a message is that it is easy to lose it. What I'm
trying to avoid here is debugging somebody's setup for hours only to find
out that they did a "pci_del" behind libvirt's back. Maybe we can just make the
<monitorpassthrough/> a read-only flag; it is ignored in the parsing, but
it is set by "GetXMLDesc" when it detects that the virDomainQemuInvokeMonitor
has been called.
--
Chris Lalancette
- [Qemu-devel] Libvirt debug API, Chris Lalancette, 2010/04/09
- Re: [Qemu-devel] Re: [libvirt] Libvirt debug API, Jamie Lokier, 2010/04/09
- Re: [Qemu-devel] Re: [libvirt] Libvirt debug API, Richard W.M. Jones, 2010/04/11
- Re: [Qemu-devel] Re: [libvirt] Libvirt debug API, Jamie Lokier, 2010/04/11
- Message not available
- Re: [libvirt] [Qemu-devel] Re: Libvirt debug API, Jamie Lokier, 2010/04/12
- Re: [libvirt] [Qemu-devel] Re: Libvirt debug API, Daniel P. Berrange, 2010/04/12
- Re: [libvirt] [Qemu-devel] Re: Libvirt debug API, Anthony Liguori, 2010/04/22
- Re: [libvirt] [Qemu-devel] Re: Libvirt debug API, Jes Sorensen, 2010/04/23