[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 03/17] virtio-serial: save/load: Ensure we have h
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH v5 03/17] virtio-serial: save/load: Ensure we have hot-plugged ports instantiated |
Date: |
Wed, 14 Apr 2010 10:58:23 +0530 |
If some ports that were hot-plugged on the source are not available on
the destination, fail migration instead of trying to deref a NULL
pointer.
Signed-off-by: Amit Shah <address@hidden>
Reported-by: Juan Quintela <address@hidden>
---
hw/virtio-serial-bus.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index d31e62d..5316ef6 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -451,6 +451,13 @@ static int virtio_serial_load(QEMUFile *f, void *opaque,
int version_id)
id = qemu_get_be32(f);
port = find_port_by_id(s, id);
+ if (!port) {
+ /*
+ * The requested port was hot-plugged on the source but we
+ * don't have it
+ */
+ return -EINVAL;
+ }
port->guest_connected = qemu_get_byte(f);
}
--
1.6.2.5
- [Qemu-devel] [PATCH v5 00/17] virtio-serial fixes, new abi for port discovery, flow control, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 01/17] virtio-serial: save/load: Ensure target has enough ports, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 02/17] virtio-serial: save/load: Ensure nr_ports on src and dest are same., Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 03/17] virtio-serial: save/load: Ensure we have hot-plugged ports instantiated,
Amit Shah <=
- [Qemu-devel] [PATCH v5 04/17] virtio-serial: save/load: Send target host connection status if different, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 05/17] virtio-serial: Use control messages to notify guest of new ports, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 06/17] virtio-serial: whitespace: match surrounding code, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 07/17] virtio-serial: Remove redundant check for 0-sized write request, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 08/17] virtio-serial: Update copyright year to 2010, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 09/17] virtio-serial: Propagate errors in initialising ports / devices in guest, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 10/17] virtio-serial: Send out guest data to ports only if port is opened, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 11/17] iov: Introduce a new file for helpers around iovs, add iov_from_buf(), Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 12/17] iov: Add iov_to_buf and iov_size helpers, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 13/17] virtio-serial: Handle scatter-gather buffers for control messages, Amit Shah, 2010/04/14