[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 14/17] virtio-serial: Handle scatter/gather input
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH v5 14/17] virtio-serial: Handle scatter/gather input from the guest |
Date: |
Wed, 14 Apr 2010 10:58:34 +0530 |
Current guests don't send more than one iov but it can change later.
Ensure we handle that case.
Signed-off-by: Amit Shah <address@hidden>
CC: Avi Kivity <address@hidden>
---
hw/virtio-serial-bus.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index b8410c3..3053a35 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -351,7 +351,8 @@ static void handle_output(VirtIODevice *vdev, VirtQueue *vq)
while (virtqueue_pop(vq, &elem)) {
VirtIOSerialPort *port;
- size_t ret;
+ uint8_t *buf;
+ size_t ret, buf_size;
port = find_port_by_vq(vser, vq);
if (!port) {
@@ -374,9 +375,12 @@ static void handle_output(VirtIODevice *vdev, VirtQueue
*vq)
goto next_buf;
}
- /* The guest always sends only one sg */
- ret = port->info->have_data(port, elem.out_sg[0].iov_base,
- elem.out_sg[0].iov_len);
+ buf_size = iov_size(elem.out_sg, elem.out_num);
+ buf = qemu_malloc(buf_size);
+ ret = iov_to_buf(elem.out_sg, elem.out_num, buf, 0, buf_size);
+
+ ret = port->info->have_data(port, buf, ret);
+ qemu_free(buf);
next_buf:
virtqueue_push(vq, &elem, ret);
--
1.6.2.5
- [Qemu-devel] [PATCH v5 04/17] virtio-serial: save/load: Send target host connection status if different, (continued)
- [Qemu-devel] [PATCH v5 04/17] virtio-serial: save/load: Send target host connection status if different, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 05/17] virtio-serial: Use control messages to notify guest of new ports, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 06/17] virtio-serial: whitespace: match surrounding code, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 07/17] virtio-serial: Remove redundant check for 0-sized write request, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 08/17] virtio-serial: Update copyright year to 2010, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 09/17] virtio-serial: Propagate errors in initialising ports / devices in guest, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 10/17] virtio-serial: Send out guest data to ports only if port is opened, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 11/17] iov: Introduce a new file for helpers around iovs, add iov_from_buf(), Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 12/17] iov: Add iov_to_buf and iov_size helpers, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 13/17] virtio-serial: Handle scatter-gather buffers for control messages, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 14/17] virtio-serial: Handle scatter/gather input from the guest,
Amit Shah <=
- [Qemu-devel] [PATCH v5 15/17] virtio-serial: Apps should consume all data that guest sends out / Fix virtio api abuse, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 16/17] virtio-serial: Discard data that guest sends us when ports aren't connected, Amit Shah, 2010/04/14
- [Qemu-devel] [PATCH v5 17/17] virtio-serial: Implement flow control for individual ports, Amit Shah, 2010/04/14
[Qemu-devel] Re: [PATCH v5 00/17] virtio-serial fixes, new abi for port discovery, flow control, Juan Quintela, 2010/04/14