qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [RfC PATCH 08/11] spice: add qxl device


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] Re: [RfC PATCH 08/11] spice: add qxl device
Date: Fri, 16 Apr 2010 12:34:55 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4

On 04/16/10 12:18, Paolo Bonzini wrote:
I'd just use __sync_fetch_and_or here.

Good idea.  I think we can zap the memory barrier and fix a small race
while being at it, see the incremental fix below.

Not sure about the memory barrier semantics of __sync_* (rth?), but
besides that the patch seems like a good idea.

I think a memory barrier isn't needed there. We don't touch anything shared beside int_pending which is only accessed using the sync op (after applying the patch).

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]