qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 1/2] block: Set backing_hd to NULL after deleting it


From: Stefan Hajnoczi
Subject: [Qemu-devel] [PATCH 1/2] block: Set backing_hd to NULL after deleting it
Date: Sat, 17 Apr 2010 10:49:06 +0100

It is safer to set backing_hd to NULL after deleting it so that any use
after deletion is obvious during development.  Happy segfaulting!

This patch should be applied after Kevin Wolf's "vmdk: Convert to
bdrv_open" so that vmdk does not segfault on close.

Signed-off-by: Stefan Hajnoczi <address@hidden>
---
 block.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/block.c b/block.c
index 12cf434..e7e74d9 100644
--- a/block.c
+++ b/block.c
@@ -523,8 +523,10 @@ unlink_and_fail:
 void bdrv_close(BlockDriverState *bs)
 {
     if (bs->drv) {
-        if (bs->backing_hd)
+        if (bs->backing_hd) {
             bdrv_delete(bs->backing_hd);
+            bs->backing_hd = NULL;
+        }
         bs->drv->bdrv_close(bs);
         qemu_free(bs->opaque);
 #ifdef _WIN32
-- 
1.7.0





reply via email to

[Prev in Thread] Current Thread [Next in Thread]