Re: [Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using -device parm

[Bruce Rogers]

    >>> On 4/14/2010 at 01:24 AM, Gerd Hoffmann <address@hidden> wrote: 
> Hi,
> 
>> When specifying ide devices using -device, the cmos information
>> which the bios depends on is not written. This patch generalizes
>> the cmos hd data setting for the existing code path and adds the
>> ability to call that code on a per machine, per ide drive basis.
> 
> Hmm.
> 
> With -device and thus alot of device setup happening after 
> QEMUMachine->init() I think it would be very useful to have 
> QEMUMachine->init_late().  There are a bunch of machine specific jobs 
> which need to be done after all devices have been plugged into the machine.
> 
> Setting up cmos is one of them.
> 
> i440fx_init_memory_mappings() could be moved there, which would allow to 
> add vga cards via -device.
> 
> And I'm pretty sure there are more use cases.  fw_cfg maybe?
> 
> Comments?
> 
> cheers,
>    Gerd

Not much traffic on this thread ;-)
I can see the usefulness of an init_late() to generalize post device setup 
issues.
I assume then that you didn't have any other issues with my patch, other than 
general code structure concerns?

Bruce