Re: [Qemu-devel] [PATCH 0/4]: QMP: Fix segfault in bad input

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

>  First, we do some QError usage cleanup in handle_qmp_command() and then
> really fix the bug in the last patch.

The bug is that we neglect to check that command object member
"arguments" is an object before we access its members.  Crashes when
it's not an object.

The rest of the patch series tweaks diagnostics of malformed command
objects:

* Split QERR_QMP_BAD_INPUT_OBJECT_MEMBER off QERR_QMP_BAD_INPUT_OBJECT.
  I don't care for that at all.  These errors are all of the "hello
  client, you're too broken to live, go away" kind.  Clients won't be
  able to do anything useful with a fine-grained error class there.

* Improve the human-readable messages.  This could be occasionally
  useful for debugging, I guess.

That said, I'm not opposed to merging as is.  There's plenty of useless
error detail already, with more to come, so adding to the pile doesn't
bother me.