[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 06/22] savevm: load_vmstate(): Improve error check
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 06/22] savevm: load_vmstate(): Improve error check |
Date: |
Tue, 20 Apr 2010 18:09:36 -0300 |
We should fail if something goes wrong in the call to
bdrv_snapshot_find().
Currently, we only fail if 'sn.vm_state_size' is not what
we expect it to be.
Signed-off-by: Luiz Capitulino <address@hidden>
---
savevm.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/savevm.c b/savevm.c
index 5024829..3ccb246 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1800,8 +1800,11 @@ int load_vmstate(const char *name)
/* Don't even try to load empty VM states */
ret = bdrv_snapshot_find(bs, &sn, name);
- if ((ret >= 0) && (sn.vm_state_size == 0))
+ if (ret < 0) {
+ return ret;
+ } else if (sn.vm_state_size == 0) {
return -EINVAL;
+ }
/* restore the VM state */
f = qemu_fopen_bdrv(bs, 0);
--
1.7.1.rc1.12.ga6018
- [Qemu-devel] [PATCH 05/22] savevm: load_vmstate(): Return 'ret' on error, (continued)
- [Qemu-devel] [PATCH 05/22] savevm: load_vmstate(): Return 'ret' on error, Luiz Capitulino, 2010/04/20
- [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string(), Luiz Capitulino, 2010/04/20
- Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string(), Daniel P. Berrange, 2010/04/21
- Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string(), Kevin Wolf, 2010/04/21
- Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string(), malc, 2010/04/21
- Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string(), Luiz Capitulino, 2010/04/21
- Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string(), Daniel P. Berrange, 2010/04/21
- Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string(), Luiz Capitulino, 2010/04/21
- Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string(), Markus Armbruster, 2010/04/21
- Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string(), Luiz Capitulino, 2010/04/22
[Qemu-devel] [PATCH 06/22] savevm: load_vmstate(): Improve error check,
Luiz Capitulino <=
[Qemu-devel] [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Luiz Capitulino, 2010/04/20
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Juan Quintela, 2010/04/20
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Luiz Capitulino, 2010/04/20
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Juan Quintela, 2010/04/21
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Luiz Capitulino, 2010/04/21
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Juan Quintela, 2010/04/21
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Kevin Wolf, 2010/04/21
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Luiz Capitulino, 2010/04/22
[Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Kevin Wolf, 2010/04/21