[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 12/22] QError: New QERR_STATEVM_SAVE_FAILED
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 12/22] QError: New QERR_STATEVM_SAVE_FAILED |
Date: |
Tue, 20 Apr 2010 23:31:22 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> wrote:
> Signed-off-by: Luiz Capitulino <address@hidden>
VMState already used for two things in qemu, but I think that changing
to StateVM _only_ on the error messages is wrong. Leave it as vmstate,
and if rest of things get ever changed, change just everything?
> ---
> qerror.c | 4 ++++
> qerror.h | 3 +++
> 2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/qerror.c b/qerror.c
> index aa6892d..95c1a95 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -197,6 +197,10 @@ static const QErrorStringTable qerror_table[] = {
> .desc = "No block device can accept snapshots",
> },
> {
> + .error_fmt = QERR_STATEVM_SAVE_FAILED,
> + .desc = "Failed to save VM state (%(reason))",
> + },
> + {
> .error_fmt = QERR_TOO_MANY_FILES,
> .desc = "Too many open files",
> },
> diff --git a/qerror.h b/qerror.h
> index 4a056b3..b915e26 100644
> --- a/qerror.h
> +++ b/qerror.h
> @@ -163,6 +163,9 @@ QError *qobject_to_qerror(const QObject *obj);
> #define QERR_SNAPSHOT_NO_DEVICE \
> "{ 'class': 'SnapshotNoDevice', 'data': {} }"
>
> +#define QERR_STATEVM_SAVE_FAILED \
> + "{ 'class': 'StateVmSaveFailed', 'data': { 'reason': %s } }"
> +
> #define QERR_TOO_MANY_FILES \
> "{ 'class': 'TooManyFiles', 'data': {} }"
- [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, (continued)
[Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Kevin Wolf, 2010/04/21
[Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Juan Quintela, 2010/04/21
Re: [Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM, Jamie Lokier, 2010/04/21
[Qemu-devel] [PATCH 09/22] QError: New QERR_SNAPSHOT_DELETE_FAILED, Luiz Capitulino, 2010/04/20
[Qemu-devel] [PATCH 12/22] QError: New QERR_STATEVM_SAVE_FAILED, Luiz Capitulino, 2010/04/20
- [Qemu-devel] Re: [PATCH 12/22] QError: New QERR_STATEVM_SAVE_FAILED,
Juan Quintela <=
[Qemu-devel] [PATCH 10/22] QError: New QERR_SNAPSHOT_CREATE_FAILED, Luiz Capitulino, 2010/04/20
[Qemu-devel] [PATCH 08/22] QError: New QERR_SNAPSHOT_NO_DEVICE, Luiz Capitulino, 2010/04/20
[Qemu-devel] [PATCH 11/22] QError: New QERR_SNAPSHOT_ACTIVATE_FAILED, Luiz Capitulino, 2010/04/20
[Qemu-devel] [PATCH 15/22] QError: New QERR_SNAPSHOT_NOT_FOUND, Luiz Capitulino, 2010/04/20
[Qemu-devel] [PATCH 14/22] QError: New QERR_DEVICE_NO_SNAPSHOT, Luiz Capitulino, 2010/04/20
[Qemu-devel] [PATCH 13/22] QError: New QERR_STATEVM_LOAD_FAILED, Luiz Capitulino, 2010/04/20
[Qemu-devel] [PATCH 17/22] savevm: delete_snapshot(): Remove unused parameter, Luiz Capitulino, 2010/04/20
[Qemu-devel] [PATCH 18/22] savevm: Convert do_delvm() to QObject, QError, Luiz Capitulino, 2010/04/20