Re: [Qemu-devel] [PATCH] fix curses update

[Bernhard Kauer]

Hi,

> I believe this issue has come up before with a similar patch but

well i've submitted such a patch more than two years ago.  Unfortunatelly
it got never applied, so that I have to patch my Qemu on every update...


> someone checked their ncurses and they didn't see the same issue. 
> I just checked and here mvwaddchnstr() does not expect a null-terminated
> string either, but it skips the \0 characters.

This is not conforming to the Single UNIX Specification, which states
that the string is shown "until a null chtype is encountered". See for
example:
  http://www.opengroup.org/onlinepubs/007908775/xcurses/addchstr.html 


>  So probably we should
> replace them with spaces or something else,  I wouldn't like to
> replace a single library call with 80 calls, it's better to go through
> the string and replace them, maybe in console_write_ch or somewhere
> else.

That would be a one-liner.  Should I send such a patch?


Thanks,

        Bernhard