[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG
From: |
Ian Molton |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG |
Date: |
Thu, 22 Apr 2010 20:06:39 +0100 |
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20091109) |
Gerd Hoffmann wrote:
> Hi,
>
>> * the SIZE property patch: Msg-Id:<address@hidden>
>
> Fine with me.
\o/
So should I re-post that patch, or can I count on that being folded into
mainline ?
>> * the socket reconnect patch: Msg-Id:<address@hidden>
>
> Not sure yet.
Comment below...
> I think it makes sense to have a separate chardev backend for it, so you
> can easily hook it up to either virtio-rng or something else, i.e.
> define a chardev for the egd connection like this:
>
> -chardev backend=egd,id=egd,server=$address,$rate-limit-options-here
Yes, I like the look of that, at least in principle.
> It might make sense to have the reconnect logic in the egd chardev
> backend then, thereby obsoleting the socket reconnect patch.
Im not sure I agree there... surely there are other things which would
benefit from generic socket reconnection support (virtio-rng cant be the
only driver that might want to rely on a reliable source of data via a
socket in a server-farm type situation?)
Do we really want to re-implement reconnection (and reconnection retry
anti-flood limiting) in every single backend?
Thanks for the review - if we can nail down the reconnection issue, I'll
set about a rework of the patchset and resubmit :-)
-Ian
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, (continued)
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Jamie Lokier, 2010/04/20
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Ian Molton, 2010/04/20
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Blue Swirl, 2010/04/20
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Jamie Lokier, 2010/04/20
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Ian Molton, 2010/04/20
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Jamie Lokier, 2010/04/20
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Gerd Hoffmann, 2010/04/21
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Jamie Lokier, 2010/04/21
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Ian Molton, 2010/04/21
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Gerd Hoffmann, 2010/04/21
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG,
Ian Molton <=
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Jamie Lokier, 2010/04/22
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Ian Molton, 2010/04/23
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Jamie Lokier, 2010/04/23
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Ian Molton, 2010/04/24
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Gerd Hoffmann, 2010/04/23
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Ian Molton, 2010/04/23
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Gerd Hoffmann, 2010/04/23
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Ian Molton, 2010/04/23
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Jamie Lokier, 2010/04/23
- Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG, Ian Molton, 2010/04/24