[Qemu-devel] Re: [RFC PATCH 00/20] Kemari for KVM v0.1

[Anthony Liguori]

On 04/22/2010 07:45 PM, Yoshiaki Tamura wrote:
> Anthony Liguori wrote:
>
> > I think it would make sense to separate out the things that are actually
> > optimizations (like the dirty bitmap changes and the writev/readv
> > changes) and to attempt to justify them with actual performance data.
>
> I agree with the separation plan.
>
> For dirty bitmap change, Avi and I discussed on patchset for upsream 
> QEMU while you were offline (Sorry, if I was wrong).  Could you also 
> take a look?

Yes, I've seen it and I don't disagree.  That said, there ought to be 
perf data in the commit log so that down the road, the justification is 
understood.

> http://lists.gnu.org/archive/html/qemu-devel/2010-04/msg01396.html
>
> Regarding writev, I agree that it should be backed with actual data, 
> otherwise it should be removed.  We attemped to do everything that may 
> reduce the overhead of the transaction.
>
> > I'd prefer not to modify the live migration protocol ABI and it doesn't
> > seem to be necessary if we're willing to add options to the -incoming
> > flag. We also want to be a bit more generic with respect to IO.
>
> I totally agree with your approach not to change the protocol ABI.  
> Can we add an option to -incoming?  Like, -incoming ft_mode, for example
> Regarding the IO, let me reply to the next message.
>
> > Otherwise, the series looks very close to being mergable.
>
> Thank you for your comment on each patch.
>
> To be honest, I wasn't that confident because I'm a newbie to KVM/QEMU 
> and struggled for how to implement in an acceptable way.

The series looks very good.  I'm eager to see this functionality merged.

Regards,

Anthony Liguori

> Thanks,
>
> Yoshi
>
> > Regards,
> >
> > Anthony Liguori