[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v3 05/12] net: slirp: use info_dict instead of i
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH v3 05/12] net: slirp: use info_dict instead of info_str |
Date: |
Fri, 23 Apr 2010 18:06:43 -0300 |
On Thu, 15 Apr 2010 11:07:00 -0300
Miguel Di Ciurcio Filho <address@hidden> wrote:
> Signed-off-by: Miguel Di Ciurcio Filho <address@hidden>
> ---
> net/slirp.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index b41c60a..eb9d261 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -32,6 +32,9 @@
> #include "monitor.h"
> #include "sysemu.h"
> #include "qemu_socket.h"
> +#include "qdict.h"
> +#include "qbool.h"
> +#include "qstring.h"
> #include "slirp/libslirp.h"
>
> static int get_str_sep(char *buf, int buf_size, const char **pp, int sep)
> @@ -240,8 +243,9 @@ static int net_slirp_init(VLANState *vlan, const char
> *model,
>
> nc = qemu_new_net_client(&net_slirp_info, vlan, NULL, model, name);
>
> - snprintf(nc->info_str, sizeof(nc->info_str),
> - "net=%s, restricted=%c", inet_ntoa(net), restricted ? 'y' :
> 'n');
> + nc->info_dict = qdict_new();
> + qdict_put(nc->info_dict, "net", qstring_from_str(inet_ntoa(net)));
> + qdict_put(nc->info_dict, "restricted", qbool_from_int(restricted));
This is going to be freed by qemu_del_vlan_client(), right?
>
> s = DO_UPCAST(SlirpState, nc, nc);
>
- [Qemu-devel] [PATCH v3 09/12] net: socket: use info_dict instead of info_str, (continued)
- [Qemu-devel] [PATCH v3 09/12] net: socket: use info_dict instead of info_str, Miguel Di Ciurcio Filho, 2010/04/15
- [Qemu-devel] [PATCH v3 07/12] net: vde: use info_dict instead of info_str, Miguel Di Ciurcio Filho, 2010/04/15
- [Qemu-devel] [PATCH v3 08/12] net: dump: use info_dict instead of info_str, Miguel Di Ciurcio Filho, 2010/04/15
- [Qemu-devel] [PATCH v3 04/12] net: various devices: replace qemu_format_nic_info_str by qemu_format_nic_info_dict, Miguel Di Ciurcio Filho, 2010/04/15
- [Qemu-devel] [PATCH v3 06/12] net: tap/tap-win32: use info_dict instead of info_str, Miguel Di Ciurcio Filho, 2010/04/15
- [Qemu-devel] [PATCH v3 03/12] net: eepro100: replace qemu_format_nic_info_str by qemu_format_nic_info_dict, Miguel Di Ciurcio Filho, 2010/04/15
- [Qemu-devel] [PATCH v3 05/12] net: slirp: use info_dict instead of info_str, Miguel Di Ciurcio Filho, 2010/04/15
- [Qemu-devel] Re: [PATCH v3 05/12] net: slirp: use info_dict instead of info_str,
Luiz Capitulino <=
- [Qemu-devel] [PATCH v3 01/12] QObject API: add qdict_to_qstring() function, Miguel Di Ciurcio Filho, 2010/04/15
- [Qemu-devel] [PATCH v3 02/12] net: add qemu_nic_format_info_dict and VLANClientState->info_dict, Miguel Di Ciurcio Filho, 2010/04/15