[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots |
Date: |
Sun, 25 Apr 2010 15:57:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Avi Kivity wrote:
> On 04/24/2010 10:34 AM, Jan Kiszka wrote:
>> Marcelo Tosatti wrote:
>>
>>> Otherwise there is no way to differentiate between global and slot
>>> specific logging, so for example
>>>
>>> vga dirty log start
>>> migration start
>>> migration fail
>>>
>>> Disables dirty logging for the vga slot.
>>>
>> This is not true (unless there is a bug): Migration logging is tracked
>> via KVMState::migration_log and vga logging via KVMSlot::flags. Both are
>> merged in kvm_set_user_memory_region. Thus no such change is required
>> for upstream.
>>
>
> It's still a good idea. The current API assumes that there will be only
> one slot-based client (or that multiple clients will keep the refcount
> themselves).
>
> After the bytemap -> multiple bitmaps conversion this can be extended to
> each client getting its own bitmap (and therefore, s/refcount/list of
> bitmaps/ and s/!refcount/list_empty()/).
>
No concerns if
- there is an existing use case for multiple clients, at least in
qemu-kvm
- the logging API is consistently converted, not just extended
(IOW, migration_log is converted to logging_count)
- someone signs he checked that current use of start/stop in qemu is
completely symmetrical (I think to remember this used to be not the
case, but I might be wrong)
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [uq/master patch 0/5] prepare for qemu-kvm's usage of upstream memslot code, Marcelo Tosatti, 2010/04/23
- [Qemu-devel] [uq/master patch 2/5] kvm: add logging count to slots, Marcelo Tosatti, 2010/04/23
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/24
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots,
Jan Kiszka <=
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/26
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Marcelo Tosatti, 2010/04/26