[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/9] QMP: Check "arguments" member's type
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 4/9] QMP: Check "arguments" member's type |
Date: |
Mon, 26 Apr 2010 12:47:28 -0300 |
Otherwise the following input crashes QEMU:
{ "execute": "migrate", "arguments": "tcp:0:4446" }
Signed-off-by: Luiz Capitulino <address@hidden>
---
monitor.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/monitor.c b/monitor.c
index 0611b29..ef84298 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4437,6 +4437,9 @@ static void handle_qmp_command(JSONMessageParser *parser,
QList *tokens)
obj = qdict_get(input, "arguments");
if (!obj) {
args = qdict_new();
+ } else if (qobject_type(obj) != QTYPE_QDICT) {
+ qerror_report(QERR_QMP_BAD_INPUT_OBJECT_MEMBER, "arguments", "object");
+ goto err_input;
} else {
args = qobject_to_qdict(obj);
QINCREF(args);
--
1.7.1.rc1.12.ga6018
- [Qemu-devel] [PATCH 0/9][PULL]: QMP/Monitor queue, Luiz Capitulino, 2010/04/26
- [Qemu-devel] [PATCH 1/9] QError: New QERR_QMP_BAD_INPUT_OBJECT_MEMBER, Luiz Capitulino, 2010/04/26
- [Qemu-devel] [PATCH 2/9] QMP: Use QERR_QMP_BAD_INPUT_OBJECT_MEMBER, Luiz Capitulino, 2010/04/26
- [Qemu-devel] [PATCH 3/9] QError: Improve QERR_QMP_BAD_INPUT_OBJECT desc, Luiz Capitulino, 2010/04/26
- [Qemu-devel] [PATCH 4/9] QMP: Check "arguments" member's type,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', Luiz Capitulino, 2010/04/26
- Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', Anthony Liguori, 2010/04/26
- Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', Luiz Capitulino, 2010/04/26
- Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', Anthony Liguori, 2010/04/26
- Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', Luiz Capitulino, 2010/04/26
- Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', Anthony Liguori, 2010/04/26
- [Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit', Jan Kiszka, 2010/04/26
- [Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit', Anthony Liguori, 2010/04/26
- [Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit', Luiz Capitulino, 2010/04/26
- [Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit', Paolo Bonzini, 2010/04/27