qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 06/10] kvm: remove explicit kvm_arch_reset_v


From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH 06/10] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu
Date: Wed, 28 Apr 2010 11:46:34 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 04/28/2010 11:22 AM, Marcelo Tosatti wrote:
On Wed, Apr 28, 2010 at 10:39:06AM -0500, Anthony Liguori wrote:
On 04/26/2010 12:59 PM, Marcelo Tosatti wrote:
This is now done via the initialization's qemu_system_reset call.

Signed-off-by: Avi Kivity<address@hidden>
---
  kvm-all.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kvm-all.c b/kvm-all.c
index 9c8aa7d..eabb097 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -208,7 +208,6 @@ int kvm_init_vcpu(CPUState *env)
      ret = kvm_arch_init_vcpu(env);
      if (ret == 0) {
          qemu_register_reset(kvm_reset_vcpu, env);
-        kvm_arch_reset_vcpu(env);
      }
  err:
      return ret;
This breaks -enable-kvm in upstream qemu.  No progress is ever made
in the guest.
These patches have been autotested, and just confirmed manually that
this patch does not break -enable-kvm (as the reset handler is now
called through the notifier).

What is your qemu command line?

x86_64-softmmu/qemu-system-x86_64 -hda ~/images/linux.img -snapshot -enable-kvm -L ~/git/qemu/pc-bios

This is with the very latest tip. I can publish a branch if that's helpful. If you have an old tree, I wouldn't be surprised if it didn't show up.

Regards,

Anthony Liguori






reply via email to

[Prev in Thread] Current Thread [Next in Thread]