Re: [Qemu-devel] [PATCH -V5 01/21] virtio-9p: Create a commandline option -fsdev

[Anthony Liguori]

On 04/15/2010 09:10 AM, Aneesh Kumar K.V wrote:
> From: Gautham R Shenoy<address@hidden>
>
> This patch creates a new command line option named -fsdev to hold any file
> system specific information.
>
> The option will currently hold the following attributes:
> -fsdev fstype id=id,path=path_to_share
> where
> fstype: Type of the file system.
> id:     Identifier used to refer to this fsdev
> path:   The path on the host that is identified by this fsdev.
>
> address@hidden: Abstraction using FsContext]
> Signed-off-by: Gautham R Shenoy<address@hidden>
> Signed-off-by: Aneesh Kumar K.V<address@hidden>
> ---
>   Makefile.objs      |    5 +++-
>   configure          |   24 +++++++++++++++++-
>   fsdev/qemu-fsdev.c |   70 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>   fsdev/qemu-fsdev.h |   53 +++++++++++++++++++++++++++++++++++++++
>   hw/file-op-9p.h    |   32 +++++++++++++++++++++++
>   qemu-config.c      |   18 +++++++++++++
>   qemu-config.h      |    3 ++
>   qemu-options.hx    |   34 +++++++++++++++++++++++++
>   vl.c               |   27 ++++++++++++++++++++
>   9 files changed, 264 insertions(+), 2 deletions(-)
>   create mode 100644 fsdev/qemu-fsdev.c
>   create mode 100644 fsdev/qemu-fsdev.h
>   create mode 100644 hw/file-op-9p.h
>
> diff --git a/Makefile.objs b/Makefile.objs
> index ab1af88..4267239 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -35,6 +35,9 @@ net-nested-$(CONFIG_SLIRP) += slirp.o
>   net-nested-$(CONFIG_VDE) += vde.o
>   net-obj-y += $(addprefix net/, $(net-nested-y))
>
> +fsdev-nested-$(CONFIG_LINUX_VIRTFS) = qemu-fsdev.o
> +fsdev-obj-$(CONFIG_LINUX_VIRTFS) += $(addprefix fsdev/, $(fsdev-nested-y))
>    

No need to make virtfs a config option.  Just use $(CONFIG_LINUX).

You also need to add fsdev to the list of directories that are created 
at the end of configure or else building from a seperate directory won't 
work.

Regards,

Anthony Liguori