Re: [Qemu-devel] [PATCH 2/2] virtio-console: Notify resize to the guest.

[Kusanagi Kouichi]

On 2010-04-29 16:17:18 +0530, Amit Shah wrote:
> On (Thu) Apr 29 2010 [16:12:38], Kusanagi Kouichi wrote:
> > On 2010-04-16 18:32:19 +0530, Amit Shah wrote:
> > > On (Fri) Apr 16 2010 [20:42:47], Kusanagi Kouichi wrote:
> > > > 
> > > > Signed-off-by: Kusanagi Kouichi <address@hidden>
> > > > ---
> > > >  hw/virtio-console.c    |    3 +++
> > > >  hw/virtio-serial-bus.c |    8 ++++++++
> > > >  hw/virtio-serial.h     |    9 +++++++--
> > > >  3 files changed, 18 insertions(+), 2 deletions(-)
> > > 
> > > Hello,
> > > 
> > > The patches look good. How did you test them?
> > > 
> > > Just one comment here:
> > > 
> > > > diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
> > > > index 17c1ec1..66891ee 100644
> > > > --- a/hw/virtio-serial-bus.c
> > > > +++ b/hw/virtio-serial-bus.c
> > > > @@ -163,6 +163,13 @@ int virtio_serial_close(VirtIOSerialPort *port)
> > > >      return 0;
> > > >  }
> > > >  
> > > > +void virtio_serial_resize(VirtIOSerialPort *port, int rows, int cols)
> > > 
> > > Would virtio_serial_resize_console() be better, since this is only to be
> > > used for console ports?
> > > 
> > 
> > It is better, I think. I will update the patch. Thanks.
> 
> Thanks.
> 
> Please include me in the CC when you send it. Also please mention how
> you test this feature.
> 
>               Amit

I put printf()s into involved functions. Then ran qemu on a terminal
emulator, and resized it.
That's how I did. Is this what you need?