Re: [Qemu-devel] [PATCH] Fix the RARP protocol ID

[Stefan Berger]

address@hidden wrote
on 04/24/2010 08:54:07 AM:


> The packet(s) sent out after migration are supposed to be RAPR type
of
> packets. If they are supposed to go anywhere useful, the RAPR ethernet
> identifier needs to be fix.
> 
> Also see http://www.iana.org/assignments/ethernet-numbers
for 0x8035 for
> RARP.

Hi! It's probably not high on the agenda, but any
reason why the created packet
looks like a RAPR packet and yet has the wrong ethernet
protocol ID? If this 
packet is sent  to tell the local switch that
the VM is now on a different 
port, why not just send an ARP request packet asking
for an IP address of 0.0.0.0 ?

   Stefan

> 
> Signed-off-by: Stefan Berger <address@hidden>
> 
> ---
>  savevm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: qemu-git/savevm.c
> ===================================================================
> --- qemu-git.orig/savevm.c
> +++ qemu-git/savevm.c
> @@ -89,7 +89,7 @@ static BlockDriverState *bs_snapshots;
>  #define SELF_ANNOUNCE_ROUNDS 5
>  
>  #ifndef ETH_P_RARP
> -#define ETH_P_RARP 0x0835
> +#define ETH_P_RARP 0x8035
>  #endif
>  #define ARP_HTYPE_ETH 0x0001
>  #define ARP_PTYPE_IP 0x0800
> 
> 
>