[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] virtio-serial: Fix check for 'assert'; prevent
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH] virtio-serial: Fix check for 'assert'; prevent NULL derefs |
Date: |
Fri, 30 Apr 2010 15:50:15 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Amit Shah <address@hidden> wrote:
> In the flush_queued_data() function, we expect port to be valid. Assert
> only for port and not port || discard.
>
> Reported-by: Juan Quintela <address@hidden>
> Signed-off-by: Amit Shah <address@hidden>
reviewed-by: Juan Quintela <address@hidden>
> ---
> hw/virtio-serial-bus.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
> index 97694d5..3ce95e8 100644
> --- a/hw/virtio-serial-bus.c
> +++ b/hw/virtio-serial-bus.c
> @@ -137,7 +137,7 @@ static void do_flush_queued_data(VirtIOSerialPort *port,
> VirtQueue *vq,
>
> static void flush_queued_data(VirtIOSerialPort *port, bool discard)
> {
> - assert(port || discard);
> + assert(port);
>
> do_flush_queued_data(port, port->ovq, &port->vser->vdev, discard);
> }